<snip> > > 18/06/2021 01:26, Honnappa Nagarahalli: > > > On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > > > > Since C11 memory model is adopted in DPDK now[1], use GCC's atomic > > > > builtins in test cases. > > > > > > as previously discussed these atomics are not "C11" they are direct > > > use of gcc builtins. please don't incorporate C11 into the title of > > > the patches or commit messages since it isn't. > > > > GCC supports 2 types of built-in atomics, __atomic_xxx[1] and > > __sync_xxx [2]. > > We need a way to distinguish between them. > > We are using "C11" as [1] says they match C++11 memory model. > > I agree it would be more correct to mention "compiler builtin" > as it is not strictly the C11 API. The log already mentions "GCC's C11 atomic builtins". I think that is correct enough and represents the change correctly.
> > > [1] https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html > > [2] https://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html > > > > > > > > please do not integrate a patch that directly uses gcc builtins and > > > extensions please maintain abstractions under the rte_ namespace. > > <snip>
