On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:


-----Original Message-----
From: Thierry Herbelot <thierry.herbe...@6wind.com>
Sent: Thursday, June 17, 2021 8:12 AM
To: Thomas Monjalon <tho...@monjalon.net>; Dumitrescu, Cristian
<cristian.dumitre...@intel.com>
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo

On 6/17/21 9:01 AM, Thomas Monjalon wrote:
Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: sta...@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitre...@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbe...@6wind.com>
[...]
-       return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
+       return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])

Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>

Thierry, thanks again, you could have actually added my ack from V1 :)

The root cause looks to be a typo indeed,
but the impact or the scope of the issue
should stated in few words in the title please.
No need to send a v3, please suggest a title and I will apply.

table: check a bucket is empty for all bucket keys

        Thierry


Hi Thierry,

I think Thomas is asking for you to send a new version of this patch with the 
title updated. Is this OK with you?


Hello Cristian

Sure !

What do you think of this title:

"table: check a bucket is empty for all bucket keys"

        Best regards

        Thierry

Thanks,
Cristian




--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

Reply via email to