Hi, Thomas Another patch '[dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile method' has nothing to do with this patch (they're just in the same patchset) and has been reviewed by ARM guys.
So please review it, thanks. On 2021/6/18 7:33, Honnappa Nagarahalli wrote: > <snip> > >> >> 24/05/2021 15:23, Chengwen Feng: >>> Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', >>> but some compiler doesn't recognize the march because it doesn't >>> support sve. >>> >>> To solve this bug we use the following scheme: >>> 1. Define 'march_base' tuple which defines support march, it should >>> arrange from lower to higher. >>> e.g. 'march_base': ['-march=armv8.1-a', '-march=armv8.2-a'] 2. Define >>> 'march_feature' tuple which defines support feature. >>> e.g. 'march_feature': ['crypto', 'sve'] >>> Note: If user defined 'march_feature', it also needs to define a valid >>> 'march_base' because 'march_feature' depends on 'march_base' when >>> checking validity. >>> 3. Select the most suitable march+feature combination based on >>> 'march_base' and 'march_feature' tuples. >>> 4. Use the selected march+feature combination as the default >>> machine_args. >>> >>> Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng") >>> >>> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> >> >> This patch is still not accepted. >> Arm maintainers, what is missing? >> Is it rejected? > Juraj is working on a more generalized solution. Not sure how it will turn > out. It would be good to wait. > >> >> >> > > > . >