Comments inline.
From: Wu, Jianyue (NSB - CN/Hangzhou) <jianyue...@nokia-sbell.com>
Sent: Wednesday, June 16, 2021 1:04 PM
To: Zhang, Qi Z <qi.z.zh...@intel.com>
Cc: dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550
Hi, Qi,
OK, thanks indeed for the explanation, appreciated😊
BTW, I see patch is Superseded, does that mean it is not needed, or need update?
[Qi:] because I assume you are required to submit a new version base on
previous comment anyway.
> 1. why only enable this for x550, is it because you only need this or you
> already know other ixgbe device has the limitation?
I’m using this x550 device, but not sure if other device would have such
limitation yet. But I’m sure that X550 can support it, because I had checked
the doc, and also tested it in the ENV.
[Qi:] I hope we can enable this for all the ixgbe family if we know there is
no limitation, I think we need to check with ixgbe maintainer.
>2 . As the patch expose the new feature of the driver, could you provide
more test information?
I tested to create new Tx Queue after rte_eth_dev_start() done and use it in my
code. But haven’t tested in DPDK code yet, like testpmd.
3. You need to update document in your patch, these include
1) doc/guides/nics/features/ixgbe.ini
2) if only x550 support runtime queue configure, you’d better to explain
this in doc/guides/nics/ixgbe.rst.
OK, thanks, will check the documents. BTW, I see that at least there is 82599,
X540, X520 is 10GE, from http://doc.dpdk.org/guides/nics/ixgbe.html, I can
check their documents, but better to have some further tests, is there any ENV
I can use to test it? Thanks.
[Qi:], I don’t think we have any public environment for testing, anyways thanks
for your contribution.
Best Regards,
Dave(Jianyue)
From: Zhang, Qi Z <qi.z.zh...@intel.com<mailto:qi.z.zh...@intel.com>>
Sent: 2021年6月16日 8:31
To: Wu, Jianyue (NSB - CN/Hangzhou)
<jianyue...@nokia-sbell.com<mailto:jianyue...@nokia-sbell.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550
Hi Jianyue:
I think you can ignore those warning.
Below are couple questions for this patch:
1. why only enable this for x550, is it because you only need this or you
already know other ixgbe device has the limitation?
2 . As the patch expose the new feature of the driver, could you provide more
test information?
3. You need to update document in your patch, these include
1) doc/guides/nics/features/ixgbe.ini
2) if only x550 support runtime queue configure, you’d better to explain
this in doc/guides/nics/ixgbe.rst.
Thanks
Qi
From: Wu, Jianyue (NSB - CN/Hangzhou)
<jianyue...@nokia-sbell.com<mailto:jianyue...@nokia-sbell.com>>
Sent: Wednesday, May 26, 2021 1:30 PM
To: Zhang, Qi Z <qi.z.zh...@intel.com<mailto:qi.z.zh...@intel.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550
Hello, Zhang, qi,
May I ask a question?
I see this patch is delegate to you.
It seems some cases are failed in this link, but are i40e cases, can we ignore
them? Because seems not related with this patch. Thanks😊
http://patches.dpdk.org/project/dpdk/patch/20210524115329.40525-1-jianyue...@nokia-sbell.com/
https://lab.dpdk.org/results/dashboard/patchsets/17199/
Thanks,
Best regards,
Dave
