Hi Jianyue:

 I think you can ignore those warning.

 Below are couple questions for this patch:
 1.  why only enable this for x550, is it because you only need this or you 
already know other ixgbe device has the limitation?
2 . As the patch expose the new feature of the driver, could you provide more 
test information?
3.  You need to update document in your patch, these include
    1) doc/guides/nics/features/ixgbe.ini
    2) if only x550 support runtime queue configure, you’d better to explain 
this in doc/guides/nics/ixgbe.rst.

Thanks
Qi

From: Wu, Jianyue (NSB - CN/Hangzhou) <jianyue...@nokia-sbell.com>
Sent: Wednesday, May 26, 2021 1:30 PM
To: Zhang, Qi Z <qi.z.zh...@intel.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550


Hello, Zhang, qi,



May I ask a question?

I see this patch is delegate to you.

It seems some cases are failed in this link, but are i40e cases, can we ignore 
them? Because seems not related with this patch. Thanks😊

http://patches.dpdk.org/project/dpdk/patch/20210524115329.40525-1-jianyue...@nokia-sbell.com/

https://lab.dpdk.org/results/dashboard/patchsets/17199/



Thanks,

Best regards,

Dave

Reply via email to