> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Thursday, May 6, 2021 6:07 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; Lu, Wenzhuo
> <wenzhuo...@intel.com>
> Subject: [PATCH] net/ice/base: fix mem allocations wrapper
>
> This is reported by our internal covscan:
>
> 1. dpdk-20.11/drivers/net/ice/base/ice_switch.c:4214: sign_extension:
> Suspicious implicit sign extension: "s_rule_size" with type "u16" (16 bits,
> unsigned) is promoted in "num_unicast * s_rule_size" to type "int"
> (32 bits, signed), then sign-extended to type "unsigned long" (64 bits,
> unsigned).
> If "num_unicast * s_rule_size" is greater than 0x7FFFFFFF, the upper bits of
> the
> result will all be 1.
>
> # 4212| s_rule_size = ICE_SW_RULE_RX_TX_ETH_HDR_SIZE;
> # 4213| s_rule = (struct ice_aqc_sw_rules_elem *)
> # 4214|-> ice_calloc(hw, num_unicast, s_rule_size);
> # 4215| if (!s_rule) {
> # 4216| status = ICE_ERR_NO_MEMORY;
>
> Even if this condition is not likely to happen, in any case, it is more
> straightforward to rely on the existing rte_calloc.
>
> Fixes: 5f0978e96220 ("net/ice/base: add OS specific implementation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Qi Zhang <qi.z.zh...@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
