From: Chengchang Tang <tangchengch...@huawei.com>
The socket ID entered by user is cast to an unsigned integer. However,
the value may be an illegal negative value, which may cause some
problems. In this case, an error should be returned.
In addition, the socket ID may be an invalid positive number, which is
also processed in this patch.
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: sta...@dpdk.org
Signed-off-by: Chengchang Tang <tangchengch...@huawei.com>
Signed-off-by: Min Hu (Connor) <humi...@huawei.com>
---
v2:
* fixed socket id type.
---
drivers/net/bonding/rte_eth_bond_args.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c
b/drivers/net/bonding/rte_eth_bond_args.c
index 8c5f90d..977f3fe 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -207,13 +207,13 @@ bond_ethdev_parse_socket_id_kvarg(const char *key
__rte_unused,
return -1;
errno = 0;
- socket_id = (uint8_t)strtol(value, &endptr, 10);
+ socket_id = (int)strtol(value, &endptr, 10);
if (*endptr != 0 || errno != 0)
return -1;
/* validate socket id value */
- if (socket_id >= 0) {
- *(uint8_t *)extra_args = (uint8_t)socket_id;
+ if (socket_id >= 0 && socket_id < RTE_MAX_NUMA_NODES) {
+ *(int *)extra_args = socket_id;
return 0;
}
return -1;
--
2.7.4
