> 20/04/2021 04:17, Liu, Lingyu: > > Hi Olivier, > > > > This new packet type will be used by iavf driver to map ECPRI hardware > packet. > > This is the patch which will use this new hardware packet type. > > http://patchwork.dpdk.org/project/dpdk/patch/20210420083817.10741-3- > li > > ngyu....@intel.com/ > > I think it does not reply Olivier's question about how it will be used. > Why is it important to report this packet type in mbuf? > > PS: please do not top-post > In current implementation(w/o this patch), when receiving a eCPRI packet, testpmd prints like this: "port 2/queue 0: received 1 packets src=00:00:00:00:00:00 - dst=00:11:22:33:44:77 - type=0x0800 - length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP - sw ptype: L2_ETHER L3_IPV4 L4_UDP - l2_len=14 - l3_len=20 - l4_len=8 - Receive queue=0x0 ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM_UNKNOWN" We can't know the hw ptype.
After adding this patch, when receiving an eCPRI packet, testpmd can print like this: " port 1/queue 0: received 1 packets src=00:00:00:00:00:00 - dst=00:11:22:33:44:11 - type=0x0800 - length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP TUNNEL_ECPRI - sw ptype: L2_ETHER L3_IPV4 L4_UDP - l2_len=14 - l3_len=20 - l4_len=8 - ECPRI packet: packet type =58001, Destination UDP port =20771 - Receive queue=0x0 ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM_UNKNOWN " Then apps can recognize the packet type using hw ptype. This supports more complete packet types and protocols. > > > > From: Olivier Matz <olivier.m...@6wind.com> > > > > > > Hi Lingyu, > > > > > > On Sat, Apr 17, 2021 at 09:25:31AM +0000, Lingyu Liu wrote: > > > > Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. > > > > > > > > Signed-off-by: Lingyu Liu <lingyu....@intel.com> > > > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > > > > > The number of available packet types for tunnels is quite low > > > (already mentionned in this thread [1]). > > > > > > [1] > > > https://patches.dpdk.org/project/dpdk/patch/20210408081720.23314-3- > > > ktejas...@marvell.com > > > > > > Can you give some details about how it will be used? For instance, > > > which driver will set it, which kind of application will use it. > > > > > > Thanks, > > > Olivier > >
