On Thu, Apr 15, 2021 at 1:09 AM McDaniel, Timothy <timothy.mcdan...@intel.com> wrote: > > > > > -----Original Message----- > > From: Jerin Jacob <jerinjac...@gmail.com> > > Sent: Wednesday, April 14, 2021 2:11 PM > > To: McDaniel, Timothy <timothy.mcdan...@intel.com> > > Cc: dpdk-dev <dev@dpdk.org>; Carrillo, Erik G <erik.g.carri...@intel.com>; > > Gage > > Eads <gage.e...@intel.com>; Van Haaren, Harry > > <harry.van.haa...@intel.com>; Jerin Jacob <jer...@marvell.com>; Thomas > > Monjalon <tho...@monjalon.net> > > Subject: Re: [dpdk-dev] [PATCH v3 26/26] event/dlb: move rte config defines > > to > > runtime devargs > > > > On Wed, Apr 14, 2021 at 1:49 AM Timothy McDaniel > > <timothy.mcdan...@intel.com> wrote: > > > > > > The new devarg names and their default values > > > are listed below. The defaults have not changed, and > > > none of these parameters are accessed in the fast path. > > > > > > poll_interval=1000 > > > sw_credit_quantai=32 > > > default_depth_thresh=256 > > > > > > Signed-off-by: Timothy McDaniel <timothy.mcdan...@intel.com> > > > > Please check CI failures. Please make this practice to see the fate of > > the patch by CI after the patch submission to avoid additional delay > > in merging the patch. > > > > http://patches.dpdk.org/project/dpdk/patch/1618344896-2090-27-git-send- > > email-timothy.mcdan...@intel.com/ > > The failures seems to be > 1) with a reference to dlb2 documentation in the 20.11 release notes
Please update the 20.11 release notes to fix the issue. > 2) an apply failure with the dqueue optimization patch. It requires the DLB > 25 patches > to have been previously installed. I added a depends-on line to its cover > sheet, but that > did not seem to help > 3) there are many false positives reported by check patches, most spelling > related. I do > not see any real issues there > > As for the code cleanup, this was very minor, such as not including mbox.h, > which we do not use. > Not sure it warrants its own patch, and I'm not sure I can even identify the > other minor cleanups, if any. > > Thanks, > Tim >
