> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Thursday, April 8, 2021 11:42 PM > To: Yu, DapengX <dapengx...@intel.com>; Li, Xiaoyun > <xiaoyun...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload > reconfig cmd > > On 4/1/2021 9:28 AM, dapengx...@intel.com wrote: > > From: Dapeng Yu <dapengx...@intel.com> > > > > Configure per queue rx offloading and per queue tx offloading command > > shouldn't trigger the rte_eth_dev_configure() to reconfigure device. > > > > The patch sets the queue reconfiguration flag only, and does not set > > the device reconfiguration flag. Therefore after port is restarted, > > rte_eth_dev_configure() will not be called again. > > > > Just to clarify the impact, was calling 'rte_eth_dev_configure()' causing any > problem, is this fixing any issue? > Or is this patch an optimization to eliminate an unnecessary call? > This patch does fix an issue, and it also eliminates an unnecessary call.
The issue is: per-queue configuration, for example: port 0 rxq 0 rx_offload jumbo_frame off triggers the per-device configuration change: the RSS key is reconfigured and changes after rte_eth_dev_configure() is called on ICE PMD driver, that cause a test case failure. There is an unnecessary call in original implementation because both cmd_config_per_queue_rx_offload_parsed() and cmd_config_per_queue_tx_offload_parsed() does not update the "port->dev_conf" which hold the port configuration, therefore there is no need to call rte_eth_dev_configure().
