On 4/1/2021 9:28 AM, dapengx...@intel.com wrote:
From: Dapeng Yu <dapengx...@intel.com>
Configure per queue rx offloading and per queue tx offloading command
shouldn't trigger the rte_eth_dev_configure() to reconfigure device.
The patch sets the queue reconfiguration flag only, and does not set the
device reconfiguration flag. Therefore after port is restarted,
rte_eth_dev_configure() will not be called again.
Just to clarify the impact, was calling 'rte_eth_dev_configure()' causing any
problem, is this fixing any issue?
Or is this patch an optimization to eliminate an unnecessary call?
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: sta...@dpdk.org
Signed-off-by: Dapeng Yu <dapengx...@intel.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 14110eb2e..b49e9f52b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void
*parsed_result,
else
port->rx_conf[queue_id].offloads &= ~single_offload;
- cmd_reconfig_device_queue(port_id, 1, 1);
+ cmd_reconfig_device_queue(port_id, 0, 1);
}
cmdline_parse_inst_t cmd_config_per_queue_rx_offload = {
@@ -16044,7 +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void
*parsed_result,
else
port->tx_conf[queue_id].offloads &= ~single_offload;
- cmd_reconfig_device_queue(port_id, 1, 1);
+ cmd_reconfig_device_queue(port_id, 0, 1);
}
cmdline_parse_inst_t cmd_config_per_queue_tx_offload = {
