Hi Cristian
> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitre...@intel.com>
> Sent: Thursday, April 8, 2021 4:14 AM
> To: Li Zhang <l...@nvidia.com>; dek...@nvidia.com; Ori Kam
> <or...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Matan
> Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>;
> lir...@marvell.com
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <tho...@monjalon.net>;
> Raslan Darawsheh <rasl...@nvidia.com>; Roni Bar Yanai
> <ron...@nvidia.com>
> Subject: RE: [PATCH 2/2] net/mvpp2: check meter packet mode
>
> External email: Use caution opening links or attachments
>
>
> > -----Original Message-----
> > From: Li Zhang <l...@nvidia.com>
> > Sent: Thursday, April 1, 2021 7:16 AM
> > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com;
> > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian
> > <cristian.dumitre...@intel.com>; lir...@marvell.com
> > Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com;
> > ron...@nvidia.com
> > Subject: [PATCH 2/2] net/mvpp2: check meter packet mode
> >
> > Currently meter algorithms only supports bytes per second(BPS).
> > Check packet_mode set to TRUE are rejected.
> >
> > Signed-off-by: Li Zhang <l...@nvidia.com>
> > ---
> > drivers/net/mvpp2/mrvl_mtr.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/mvpp2/mrvl_mtr.c
> > b/drivers/net/mvpp2/mrvl_mtr.c index 2fa5cb43ad..055be6f6b1 100644
> > --- a/drivers/net/mvpp2/mrvl_mtr.c
> > +++ b/drivers/net/mvpp2/mrvl_mtr.c
> > @@ -88,6 +88,12 @@ mrvl_meter_profile_add(struct rte_eth_dev *dev,
> > uint32_t meter_profile_id,
> > NULL,
> > "Only srTCM RFC 2697 is
> > supported\n");
> >
> > + if (profile->packet_mode)
> > + return -rte_mtr_error_set(error, EINVAL,
> > +
> > RTE_MTR_ERROR_TYPE_UNSPECIFIED,
>
> Can you please add a new error type for this specific error case, i.e.
> RTE_MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE.
>
Thanks, I will add it in V2 patch.
> > + NULL,
> > + "Packet mode is not
> > + supported\n");
> > +
> > prof = mrvl_mtr_profile_from_id(priv, meter_profile_id);
> > if (prof)
> > return -rte_mtr_error_set(error, EEXIST,
> > --
> > 2.27.0
