Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD

[Thomas Monjalon]

01/04/2021 08:52, Li Zhang:
> From: Thomas Monjalon <tho...@monjalon.net>
> > 01/04/2021 08:16, Li Zhang:
> > > Currently meter algorithms only supports rate is bytes per second(BPS).
> > > Add packet_mode flag in meter profile parameters data structure in RTE.
> > 
> > What means RTE?
> > I see no flag added in these patches.
> 
> It is RTE API, which added by another patch as below:
> Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/patch/20210331085405.1445546-2-l...@nvidia.com/

Please do not say RTE API, it is meaningless.
Better to give the exact name of the structure,
or at least the name of the library.

Also your sentence means this patchset is adding a flag but it is not.
It's very confusing.

> > > Add the necessary checks to the existing drivers implementing the
> > > rte_mtr API to makes sure that profiles with packet_mode set to TRUE
> > > are rejected.
> > >
> > > Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&amp;dat
> > a=04
> > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%7C4
> > 3083d1
> > >
> > 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno
> > wn%7CTWF
> > >
> > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> > I6M
> > >
> > n0%3D%7C1000&amp;sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1
> > ZP4%3D&
> > > amp;reserved=0
> > 
> > It seems these patches should be part of the above patchset.
> > 
> > > Li Zhang (2):
> > >   net/softnic: check meter packet mode
> > >   net/mvpp2: check meter packet mode