Hi Thomas, I agree with the "ifcvf" name, as there might be more than one driver in a single driver dir.
Thanks, Xiao > -----Original Message----- > From: Xu, Rosen <rosen...@intel.com> > Sent: Tuesday, April 6, 2021 5:48 PM > To: Thomas Monjalon <tho...@monjalon.net>; Wang, Xiao W > <xiao.w.w...@intel.com> > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com>; > Hemant Agrawal <hemant.agra...@nxp.com>; Ajit Khaparde > <ajit.khapa...@broadcom.com>; Griffin, John <john.grif...@intel.com>; > Trahe, Fiona <fiona.tr...@intel.com>; Jain, Deepak K > <deepak.k.j...@intel.com>; Raveendra Padasalagi > <raveendra.padasal...@broadcom.com>; Vikas Gupta > <vikas.gu...@broadcom.com>; John W. Linville <linvi...@tuxdriver.com>; > Chas Williams <ch...@att.com>; Min Hu (Connor) > <humi...@huawei.com>; Zhang, Tianfei <tianfei.zh...@intel.com>; Nipun > Gupta <nipun.gu...@nxp.com>; david.march...@redhat.com > Subject: RE: [PATCH v2 3/3] drivers: align log names > > HI Thomas, > > I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your > reminder. > > > -----Original Message----- > > From: Thomas Monjalon <tho...@monjalon.net> > > Sent: Tuesday, April 06, 2021 17:31 > > To: Xu, Rosen <rosen...@intel.com>; Wang, Xiao W > > <xiao.w.w...@intel.com> > > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com>; > > Hemant Agrawal <hemant.agra...@nxp.com>; Ajit Khaparde > > <ajit.khapa...@broadcom.com>; Griffin, John <john.grif...@intel.com>; > > Trahe, Fiona <fiona.tr...@intel.com>; Jain, Deepak K > > <deepak.k.j...@intel.com>; Raveendra Padasalagi > > <raveendra.padasal...@broadcom.com>; Vikas Gupta > > <vikas.gu...@broadcom.com>; John W. Linville <linvi...@tuxdriver.com>; > > Chas Williams <ch...@att.com>; Min Hu (Connor) > <humi...@huawei.com>; > > Zhang, Tianfei <tianfei.zh...@intel.com>; Nipun Gupta > > <nipun.gu...@nxp.com>; david.march...@redhat.com > > Subject: Re: [PATCH v2 3/3] drivers: align log names > > > > Hi Rosen, > > > > You already gave your ack in previous version, no need to re-ack. > > Instead, please give your opinion and explanation as requested below. > > We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke. > > The use of AFU in the driver is not clear. > > > > Xiao, we need your opinion as well about ifcvf vs ifc name. > > > > > > > > The log levels are configured by using the name of the logs. > > > > Some drivers are aligned to follow a common log name standard: > > > > pmd.class.driver[.sub] > > > > Some "common" drivers skip the "class" part: > > > > pmd.driver.sub > > > > > > > > Two drivers have exceptions to be clarified: > > > > pmd.vdpa.ifcvf instead of pmd.vdpa.ifc > > > > pmd.afu.ipn3ke instead of pmd.net.ipn3ke > > > > > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > > > > Acked-by: Rosen Xu <rosen...@intel.com> > > > > Acked-by: Xiao Wang <xiao.w.w...@intel.com> > > > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > > > Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > > [...] > > > Acked-by: Rosen Xu <rosen...@intel.com> > > > >
