> -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Burakov, Anatoly > Sent: Friday, April 2, 2021 10:36 AM > To: dev@dpdk.org > Cc: Hunt, David <david.h...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency > handling > > On 02-Apr-21 10:26 AM, Anatoly Burakov wrote: > > Previous fix for base frequency handling in pstate mode introduced a > > couple of issues: > > > > - When base_frequency file does not exist, it simply bails out because > > of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is > > incorrect, as absence of this file is not fatal and is in fact > > expected on kernel versions earlier than 5.3 > > - When base_frequency file does exist, it gets opened, but never gets > > closed, resulting in a resource leak > > > > Both issues also manifest themselves as Coverity defects (dead code, > > and a resource leak), so this fix addresses both. > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > > ---
Acked-by: Reshma Pattan <reshma.pat...@intel.com>
