Hi,
-----Original Message-----
From: Huang, Wei <wei.hu...@intel.com>
Sent: Wednesday, March 17, 2021 4:22 PM
To: dev@dpdk.org; Xu, Rosen <rosen...@intel.com>; Zhang, Qi Z
<qi.z.zh...@intel.com>
Cc: sta...@dpdk.org; Zhang, Tianfei <tianfei.zh...@intel.com>; Huang, Wei
<wei.hu...@intel.com>
Subject: [PATCH v1 4/4] raw/ifpga/base: check pointer before dereferencing
In init_sec_mgr(), pointer "hw" may be NULL, so "hw" should be checked before
dereferencing.
Coverity issue: 367483
Fixes: 7a4f3993f269 ("raw/ifpga: add FPGA RSU APIs")
Signed-off-by: Wei Huang <wei.hu...@intel.com>
---
drivers/raw/ifpga/base/ifpga_sec_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga/base/ifpga_sec_mgr.c
b/drivers/raw/ifpga/base/ifpga_sec_mgr.c
index 4cf1db3049..15fb5b6d4d 100644
--- a/drivers/raw/ifpga/base/ifpga_sec_mgr.c
+++ b/drivers/raw/ifpga/base/ifpga_sec_mgr.c
@@ -610,7 +610,7 @@ int init_sec_mgr(struct ifpga_fme_hw *fme)
smgr->rsu_status = NULL;
}
- if ((hw->pci_data->device_id == IFPGA_N3000_DID) &&
+ if (hw && (hw->pci_data->device_id == IFPGA_N3000_DID) &&
(hw->pci_data->vendor_id == IFPGA_N3000_VID)) {
smgr->ops = &n3000_sec_ops;
smgr->copy_speed = IFPGA_N3000_COPY_SPEED;
--
2.29.2
Acked-by: Rosen Xu <rosen...@intel.com>
