> -----Original Message-----
> From: Huang, Wei <wei.hu...@intel.com>
> Sent: 2021年3月17日 16:22
> To: dev@dpdk.org; Xu, Rosen <rosen...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>
> Cc: sta...@dpdk.org; Zhang, Tianfei <tianfei.zh...@intel.com>; Huang, Wei
> <wei.hu...@intel.com>
> Subject: [PATCH v1 2/4] raw/ifpga/base: check return value of lseek
>
> In write_flash_image(), calling function "lseek" without checking return value
> has risk. Negative return value should be handled as an error condition.
>
> Coverity issue: 367478
> Fixes: 7a4f3993f269 ("raw/ifpga: add FPGA RSU APIs")
>
> Signed-off-by: Wei Huang <wei.hu...@intel.com>
> ---
> drivers/raw/ifpga/base/ifpga_fme_rsu.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga/base/ifpga_fme_rsu.c
> b/drivers/raw/ifpga/base/ifpga_fme_rsu.c
> index d32f1eccb1..a4cb2f54ba 100644
> --- a/drivers/raw/ifpga/base/ifpga_fme_rsu.c
> +++ b/drivers/raw/ifpga/base/ifpga_fme_rsu.c
> @@ -130,7 +130,12 @@ static int write_flash_image(struct ifpga_sec_mgr
> *smgr, const char *image,
> do {
> to_transfer = (length > IFPGA_RSU_DATA_BLK_SIZE) ?
> IFPGA_RSU_DATA_BLK_SIZE : length;
> - lseek(fd, offset, SEEK_SET);
> + if (lseek(fd, offset, SEEK_SET) < 0) {
> + dev_err(smgr, "Failed to seek in \'%s\' [e:%s]\n",
> + image, strerror(errno));
> + ret = -EIO;
> + goto end;
> + }
> read_size = read(fd, buf, to_transfer);
> if (read_size < 0) {
> dev_err(smgr, "Failed to read from \'%s\' [e:%s]\n",
> --
Acked-by: Tianfei zhang <tianfei.zh...@intel.com>
