>-----Original Message----- >From: Ferruh Yigit <ferruh.yi...@intel.com> >Sent: Tuesday, March 9, 2021 12:22 AM >To: Xueming(Steven) Li <xuemi...@nvidia.com>; Andrew Rybchenko ><andrew.rybche...@oktetlabs.ru> >Cc: dev@dpdk.org; Slava Ovsiienko <viachesl...@nvidia.com>; Asaf Penso ><as...@nvidia.com>; NBU-Contact-Thomas Monjalon ><tho...@monjalon.net>; declan.dohe...@intel.com >Subject: Re: [PATCH v8 2/9] ethdev: support representor port list > >On 3/8/2021 3:58 PM, Xueming(Steven) Li wrote: >> >>> -----Original Message----- >>> From: Ferruh Yigit <ferruh.yi...@intel.com> >>> Sent: Monday, March 8, 2021 10:38 PM >>> To: Xueming(Steven) Li <xuemi...@nvidia.com>; Andrew Rybchenko >>> <andrew.rybche...@oktetlabs.ru> >>> Cc: dev@dpdk.org; Slava Ovsiienko <viachesl...@nvidia.com>; Asaf >>> Penso <as...@nvidia.com>; NBU-Contact-Thomas Monjalon >>> <tho...@monjalon.net>; declan.dohe...@intel.com >>> Subject: Re: [PATCH v8 2/9] ethdev: support representor port list >>> >>> On 3/4/2021 2:30 PM, Xueming Li wrote: >>>> To support extended representor syntax, this patch extends the >>>> representor list parsing to support for representor port range in >>>> devargs, examples: >>>> representor=[1,2,3] - single list >>>> representor=[1,3-5,7,9-11] - list with singles and ranges >>>> >>> >>> Isn't above syntax already supported, can you please document what is added? >>> >>> From documentation, what already supported is: >>> -w pci:dbdf,representor=0 >>> -w pci:dbdf,representor=[0-3] >>> -w pci:dbdf,representor=[0,5-11] >>> >> >> Just a refactor to prepare for the extended representor syntax which need to >> reuse the value parsing function for controller and pf >section. >> > >OK, can you please highlight this is a refactoring, from patch title and >commit log it feels like new syntax support is added.
Sure. > >>> >>>> Signed-off-by: Xueming Li <xuemi...@nvidia.com> >>>> Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> >>>> Acked-by: Thomas Monjalon <tho...@monjalon.net> >>>> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >>> >>> >>> <...> >>> >>