Hi Thomas,
2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon at 6wind.com>: > Hi Vladimir, > Thanks for fixing. > Comments below. > > 2015-07-28 09:06, Vladimir Medvedkin: > > Signed-off-by: Vladimir Medvedkin <medvedkinv at gmail.com> > > Please explain how it was broken and how you fixed it. > It would be interesting to know which part is __SSE3__ and __SSE__. > As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html compilation fails on non x86 architectures( in that case it was tile). So I add for optimized code, which uses SSE3 intrinsics, non optimized general version. > > > +#ifdef __SSE3__ > > +#include <rte_vect.h> > > +#endif /* __SSE3__ */ > > Comments after short ifdef block are not needed. > Should I delete it? > > > +#ifndef XMM_SIZE > > +#define XMM_SIZE 16 > > Why is it needed? > because there is no defines for XMM_SIZE on non X86 architectures Regards, Vladimir
