Add a check on versioned symbol duplicates in map files. Signed-off-by: David Marchand <david.march...@redhat.com> --- This check could be added to buildtools/check-symbols.sh so that regular developers catch the issue when building their changes... Opinions?
--- devtools/check-symbol-maps.sh | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index c3cbcaf720..a430de7f64 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -35,6 +35,21 @@ if [ -n "$orphan_symbols" ] ; then ret=1 fi +find_duplicate_symbols () +{ + for map in $(find lib drivers -name '*.map') ; do + ! buildtools/map-list-symbol.sh $map | \ + sort | uniq -c | grep -v " 1 $map" + done +} + +duplicate_symbols=$(find_duplicate_symbols) +if [ -n "$duplicate_symbols" ] ; then + echo "Found duplicates in symbol map file:" + echo "$duplicate_symbols" + ret=1 +fi + find_orphan_windows_symbols () { for def in $(find lib drivers -name '*_exports.def') ; do -- 2.23.0