On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: > > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > > > > >> -----Original Message----- > >> From: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > >> Sent: Wednesday, February 3, 2021 7:08 AM > >> To: Rong, Leyi <leyi.r...@intel.com> > >> Cc: david.march...@redhat.com; Zhang, Qi Z <qi.z.zh...@intel.com>; Yigit, > >> Ferruh <ferruh.yi...@intel.com>; tho...@monjalon.net; Richardson, Bruce > >> <bruce.richard...@intel.com>; tal...@nvidia.com; Kadam, Pallavi > >> <pallavi.ka...@intel.com>; Menon, Ranjit <ranjit.me...@intel.com>; Xing, > >> Beilei <beilei.x...@intel.com>; acon...@redhat.com; dev@dpdk.org; > >> c...@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW > >> > >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote: > >>> Adds extra cflags '-fno-asynchronous-unwind-tables' > >>> to avoid the MinGW build error: > >>> Error: invalid register for .seh_savexmm > >>> > >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW") > >>> > >>> Signed-off-by: Leyi Rong <leyi.r...@intel.com> > >> > >> Tested-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > >> > >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, I > >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it that > >> this > >> option somehow affects GCC inlining heuristics. Similar issue existed in > >> librte_acl (at least a year ago win GCC 6, I believe), where GCC generated > >> incorrect code unless certain functions had been inlined (caught by test > >> app). > >> No an AVX expert, just my 2c. > > > > Applied to dpdk-next-net-intel. > > > > Hi Thomas, David, > > Do you prefer to get this directly to the main repo, since it is fixing the > windows build?
I have no issue with the main branch for mingw. The windows builds at UNH seem unavailable, so we can wait for the next-net merge. -- David Marchand