Re: [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support

[Andrew Boyer]

> On Jan 27, 2021, at 12:30 PM, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
> 
> On 1/18/2021 8:35 PM, Andrew Boyer wrote:
>> The ionic PMD only supports TX queue version 1 or greater.
>> Version 1 introduced a new SGL format with support for more
>> fragments per descriptor.
>> Signed-off-by: Andrew Boyer <abo...@pensando.io>
> 
> <...>
> 
>> @@ -925,6 +925,11 @@ ionic_lif_alloc(struct ionic_lif *lif)
>>      ionic_lif_queue_identify(lif);
>>  +   if (lif->qtype_info[IONIC_QTYPE_TXQ].version < 1) {
>> +            IONIC_PRINT(ERR, "FW too old, please upgrade");
>> +            return -ENXIO;
>> +    }
>> +
> 
> Will this affect the end users, if they were using old FW?
> 
> Can you please document this new limitation in the diriver documentation and 
> in the release notes?

I will come up with something.

We don’t believe it’s possible for anyone to be using FW that old; there were 
only a few customers with cards back then and all have been upgraded. We 
decided that locking old FW out would be better than adding complexity in the 
hot path to handle the old data structures.

-Andrew