On 1/22/21 10:11 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coque...@redhat.com>
>> Sent: Wednesday, January 20, 2021 5:25 AM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo....@intel.com>; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin <maxime.coque...@redhat.com>
>> Subject: [PATCH v2 43/44] net/virtio: improve Vhost-user error logging
>>
>> This patch improves error logging in vhost_user_read,
>> especially printing errno when recv() fails.
>>
>> Suggested-by: Adrian Moreno <amore...@redhat.com>
>> Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
>> ---
>> drivers/net/virtio/virtio_user/vhost_user.c | 29 ++++++++++++---------
>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c
>> b/drivers/net/virtio/virtio_user/vhost_user.c
>> index f046655af6..be91c99cea 100644
>> --- a/drivers/net/virtio/virtio_user/vhost_user.c
>> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
>> @@ -148,38 +148,43 @@ vhost_user_read(int fd, struct vhost_user_msg *msg)
>> int ret, sz_hdr = VHOST_USER_HDR_SIZE, sz_payload;
>>
>> ret = recv(fd, (void *)msg, sz_hdr, 0);
>> - if (ret < sz_hdr) {
>> + if (ret < 0) {
>> + PMD_DRV_LOG(ERR, "Failed to recv msg header: %s",
>> strerror(errno));
>> + return -1;
>> + } else if (ret < sz_hdr) {
>> PMD_DRV_LOG(ERR, "Failed to recv msg hdr: %d instead of %d.",
>> ret, sz_hdr);
>> - goto fail;
>> + return -1;
>> }
>>
>> /* validate msg flags */
>> if (msg->flags != (valid_flags)) {
>> PMD_DRV_LOG(ERR, "Failed to recv msg: flags %x instead of %x.",
>> msg->flags, valid_flags);
>> - goto fail;
>> + return -1;
>
> Since you are here, also add '0x' before '%x' here?
Done.
> Thanks,
> Chenbo
Thanks,
Maxime
