On 1/22/21 10:06 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coque...@redhat.com>
>> Sent: Wednesday, January 20, 2021 5:25 AM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo....@intel.com>; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin <maxime.coque...@redhat.com>
>> Subject: [PATCH v2 42/44] net/virtio: move Vhost-vDPA data to its backend
>>
>> As done earlier for Vhost-user and Vhost-kernel, this
>> patch moves the Vhost-vDPA specific data to its backend
>> file.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
>> ---
>> drivers/net/virtio/virtio_user/vhost_vdpa.c | 120 +++++++++++++-----
>> .../net/virtio/virtio_user/virtio_user_dev.h | 4 -
>> 2 files changed, 89 insertions(+), 35 deletions(-)
>>
...
>>
>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> b/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> index 36a9cadcad..9a6723da24 100644
>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> @@ -29,9 +29,6 @@ struct virtio_user_dev {
>> enum virtio_user_backend_type backend_type;
>> bool is_server; /* server or client mode */
>>
>> - /* for vhost_vdpa backend */
>> - int vhostfd;
>> -
>> /* for both vhost_user and vhost_kernel */
>
> I remember you agreed that this comment is no longer needed?
Indeed, I missed to remove it. Done now.
> I also noticed that there're multiple calls of PMD_DRV_LOG that add
> '\n' in the end, which is necessary. But, let's clean it up later..
Yes, there may still be redundant new lines at some places, I agree we
fix that later.
> With above fixed:
>
> Reviewed-by: Chenbo Xia <chenbo....@intel.com>
>
Thanks,
Maxime
