On 1/21/21 7:47 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coque...@redhat.com>
>> Sent: Wednesday, January 20, 2021 5:25 AM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo....@intel.com>; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin <maxime.coque...@redhat.com>
>> Subject: [PATCH v2 19/44] net/virtio: move features definition to generic
>> header
>>
>> This patch moves all the Virtio definition to the generic
>> header. It also renames some helpers to no more reference
>> PCI.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
>> ---
>> drivers/net/virtio/meson.build | 3 +-
>> drivers/net/virtio/virtio.c | 22 ++++
>> drivers/net/virtio/virtio.h | 94 +++++++++++++++
>> drivers/net/virtio/virtio_ethdev.c | 114 +++++++++---------
>> drivers/net/virtio/virtio_pci.c | 21 +---
>> drivers/net/virtio/virtio_pci.h | 90 --------------
>> drivers/net/virtio/virtio_ring.h | 2 +-
>> drivers/net/virtio/virtio_rxtx.c | 38 +++---
>> drivers/net/virtio/virtio_rxtx_packed.h | 6 +-
>> .../net/virtio/virtio_user/vhost_kernel_tap.c | 2 +-
>> drivers/net/virtio/virtio_user_ethdev.c | 6 +-
>> drivers/net/virtio/virtqueue.c | 4 +-
>> drivers/net/virtio/virtqueue.h | 8 +-
>> 13 files changed, 211 insertions(+), 199 deletions(-)
>> create mode 100644 drivers/net/virtio/virtio.c
>>
>> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
>> index f2873d6180..d595cfdcab 100644
>> --- a/drivers/net/virtio/meson.build
>> +++ b/drivers/net/virtio/meson.build
>
> <snip>
>
>>
>> - if (vtpci_with_feature(hw, VIRTIO_F_RING_PACKED)) {
>> + if (virtio_with_feature(hw, VIRTIO_F_RING_PACKED)) {
>
> As discussed before, let's also replace here with virtio_with_packed_queue 😊
Indeed, I missed that one.
It is fixed now and will be in v3.
Thanks,
Maxime
> Thanks
> Chenbo
