+ Liron, Allain > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Monday, January 18, 2021 2:37 PM > To: Juraj Linkeš <juraj.lin...@pantheon.tech> > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ajit.khapa...@broadcom.com; > ferruh.yi...@intel.com; abo...@pensando.io; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds > > 15/01/2021 14:26, Juraj Linkeš: > > A few options that disabled drivers in the old makefiles were > > improperly ported to the meson build system. Fix this by adding a to > > the list of > > "by adding a" what?
This is a typo, the "a" should not be there. Would that be ok wording? > > > disabled drivers, similarly how the command line option works and > > remove unneeded driver options ported from the old makefile system, > > since they don't work in the current Meson build system. > > Add support for removing drivers for cross builds so that we can > > disable them in cross files. > > Why disabling them? > If a driver is not supported it should disable itseld in its meson file. > This is helpful when building for an SoC where we don't want to build to build a driver, but the build machine actually supports the driver. I believe in this case the meson build system would find the dependencies and designate the driver to be build, but we don't want to build the driver for that SoC. There may be other reasons as well - Honnappa or others from the Arm community may shed more light on this. > [...] > > --- a/config/arm/arm64_armada_linux_gcc > > +++ b/config/arm/arm64_armada_linux_gcc > > @@ -18,3 +18,4 @@ implementer_id = '0x56' > > part_number = '0xd08' > > max_lcores = 16 > > max_numa_nodes = 1 > > +disabled_drivers = ['bus/dpaa', 'bus/fslmc', 'common/dpaax'] > > It's removing NXP drivers on Marvell SoC. Fine. > And what about other useless drivers? > I only removed what was in the old Makefiles, so I don't really know. Liron or Jerin may be able to give us some insight. > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > +# disable Arm drivers for all builds > > +disabled_drivers += ['net/avp', 'net/fm10k'] > > Why disabling avp and fm10k? Did they do something wrong to be banned? > > > This config is not only in the old Makefiles, but also in the current meson build system. I believe Jerin and Allain are the original authors, so they may be able to answer.
