19/01/2021 08:56, Xueming(Steven) Li: > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > >On 1/19/21 10:37 AM, Xueming(Steven) Li wrote: > >> From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > >>> On 1/18/21 2:16 PM, Xueming Li wrote: > >>>> +/** Ethernet device representor type */ enum > >>>> +rte_eth_representor_type { > >>>> + RTE_ETH_REPRESENTOR_NONE, /**< not a representor. */ > >>>> + RTE_ETH_REPRESENTOR_VF, /**< representor of VF. */ > >>>> + RTE_ETH_REPRESENTOR_SF, /**< representor of SF. */ > >>>> + RTE_ETH_REPRESENTOR_PF, /**< representor of host PF. */ > >>> > >>> RTE_ETH_REPRESENTOR_SF and PF looks dead in the patch. > >>> IMHO, addition of these members here make future patches which add > >>> support inconsistent. > >> > >> Yes, later patch in this patchset will support it. > > > >I know. The question is why it is not added in the later patches when these > >types are actually supported. > > Good suggestion, will update
+1 (I was sure it was already the case)