18/01/2021 12:16, Xueming Li: > To support extended representor syntax, this patch extends the > representor list parsing to support for representor port range in > devargs, examples: > representor=[1,2,3] - single list > representor=[1,3-5,7,9-11] - list with singles and ranges > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com>
Parsing functions are usually difficult to read. If you need to do another version, I would recommend adding an oneline comment on top of parsing functions to give a hint about what it is really doing. Here, > +static int > +rte_eth_devargs_enlist(uint16_t *list, uint16_t *len_list, > + const uint16_t max_list, uint16_t val) here, > +static char * > rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list, > const uint16_t max_list) here, > +static char * > +rte_eth_devargs_process_list(char *str, uint16_t *list, uint16_t *len_list, > + const uint16_t max_list) and also for this old one: > @@ -121,6 +115,9 @@ rte_eth_devargs_parse_representor_ports(char *str, void > *data)
