Hi Qi, > -----Original Message----- > From: Zhang, Qi Z <qi.z.zh...@intel.com> > Sent: Tuesday, January 19, 2021 11:45 AM > To: Ding, Xuan <xuan.d...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > Xing, Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling > > > > > -----Original Message----- > > From: Ding, Xuan <xuan.d...@intel.com> > > Sent: Monday, January 18, 2021 4:28 PM > > To: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing > > <jingjing...@intel.com>; > > Xing, Beilei <beilei.x...@intel.com> > > Cc: dev@dpdk.org; Ding, Xuan <xuan.d...@intel.com>; sta...@dpdk.org > > Subject: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling > > > > Allow error to be returned for VIRTCHNL_OP_SET_RSS_HENA when set hena = > 0. > > Add warning that PF does not support hena = 0 now. > > Actually this is not a fix, it’s a workaround to handle some defect in legacy > kernel driver. > So changed title and commit log as below: > > Title: workaround RSS cleanup failure handling > > Allow to ignore error returned from virtual channel command > VIRTCHNL_OP_SET_RSS_HENA with hena = 0 due to some legacy > kernel driver does not support this. Add warning message when > this happen. > > > > > Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS") > > The fix line should be removed. > > > Cc: sta...@dpdk.org
Since fix line is removed, should CC to stable also be removed? Thanks for your correction. Regards, Xuan > > > > Signed-off-by: Xuan Ding <xuan.d...@intel.com> > > Acked by: Qi Zhang <qi.z.zh...@intel.com> > > Applied to dpdk-next-net-intel. > > Thanks > Qi