On Wed, 23 Dec 2020 11:44:31 +0000, Tal Shnaiderman wrote:
> > > diff --git a/lib/librte_eal/windows/meson.build
> > > b/lib/librte_eal/windows/meson.build
> > > index 3b2faf29eb..1f1398dfe9 100644
> > > --- a/lib/librte_eal/windows/meson.build
> > > +++ b/lib/librte_eal/windows/meson.build
> > > @@ -21,4 +21,10 @@ sources += files(
> > > 'getopt.c',
> > > )
> > >
> > > +if (dpdk_conf.has('use_external_pthread'))
> >
> > Please describe the new option in meson_options.txt.
> > Maybe drop "external" from the name, what do you think?
>
> How about use_windows_pthread to be clear that it's unrelated to UNIX
> pthreads?
Sounds good.
