Re: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control

[Michael Shamis]

Reviewed-by: Michael Shamis <michae...@marvell.com>

-----Original Message-----
From: dev <dev-boun...@dpdk.org> On Behalf Of lir...@marvell.com
Sent: Wednesday, December 2, 2020 12:12 PM
To: Jerin Jacob Kollanukkaran <jer...@marvell.com>
Cc: dev@dpdk.org; Yuri Chipchev <yu...@marvell.com>; Liron Himi 
<lir...@marvell.com>
Subject: [dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control

From: Yuri Chipchev <yu...@marvell.com>

add tx flow control operations.

Signed-off-by: Yuri Chipchev <yu...@marvell.com>
Reviewed-by: Liron Himi <lir...@marvell.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 59 ++++++++++++++++++++++++++++-----
 1 file changed, 51 insertions(+), 8 deletions(-)

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c 
index d1bb4c35a..f80843c63 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -2049,6 +2049,19 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
 
        fc_conf->mode = en ? RTE_FC_RX_PAUSE : RTE_FC_NONE;
 
+       ret = pp2_ppio_get_tx_pause(priv->ppio, &en);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to read tx pause state");
+               return ret;
+       }
+
+       if (en) {
+               if (fc_conf->mode == RTE_FC_NONE)
+                       fc_conf->mode = RTE_FC_TX_PAUSE;
+               else
+                       fc_conf->mode = RTE_FC_FULL;
+       }
+
        return 0;
 }
 
@@ -2067,6 +2080,9 @@ static int
 mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)  {
        struct mrvl_priv *priv = dev->data->dev_private;
+       struct pp2_ppio_tx_pause_params mrvl_pause_params;
+       int ret;
+       int rx_en, tx_en;
 
        if (!priv)
                return -EPERM;
@@ -2081,16 +2097,43 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
                return -EINVAL;
        }
 
-       if (fc_conf->mode == RTE_FC_NONE ||
-           fc_conf->mode == RTE_FC_RX_PAUSE) {
-               int ret, en;
+       switch (fc_conf->mode) {
+       case RTE_FC_FULL:
+               rx_en = 1;
+               tx_en = 1;
+               break;
+       case RTE_FC_TX_PAUSE:
+               rx_en = 0;
+               tx_en = 1;
+               break;
+       case RTE_FC_RX_PAUSE:
+               rx_en = 1;
+               tx_en = 0;
+               break;
+       case RTE_FC_NONE:
+               rx_en = 0;
+               tx_en = 0;
+               break;
+       default:
+               MRVL_LOG(ERR, "Incorrect Flow control flag (%d)",
+                        fc_conf->mode);
+               return -EINVAL;
+       }
 
-               en = fc_conf->mode == RTE_FC_NONE ? 0 : 1;
-               ret = pp2_ppio_set_rx_pause(priv->ppio, en);
-               if (ret)
-                       MRVL_LOG(ERR,
-                               "Failed to change flowctrl on RX side");
+       /* Set RX flow control */
+       ret = pp2_ppio_set_rx_pause(priv->ppio, rx_en);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to change RX flowctrl");
+               return ret;
+       }
 
+       /* Set TX flow control */
+       mrvl_pause_params.en = tx_en;
+       /* all inqs participate in xon/xoff decision */
+       mrvl_pause_params.use_tc_pause_inqs = 0;
+       ret = pp2_ppio_set_tx_pause(priv->ppio, &mrvl_pause_params);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to change TX flowctrl");
                return ret;
        }
 
--
2.28.0