[dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding

[Tomasz Kulasek]

When device is added to the bonding, the link status callback is added to
the slave's eth_dev->link_intr_cbs list. This list is not initialized for
null pmd and adding it to the bonding segfaults application.

This patch allocates and sets up required structures.

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek at intel.com>
---
 drivers/net/null/rte_eth_null.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index e244595..a8b3191 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -386,6 +386,7 @@ eth_dev_null_create(const char *name,
        const unsigned nb_rx_queues = 1;
        const unsigned nb_tx_queues = 1;
        struct rte_eth_dev_data *data = NULL;
+       struct eth_driver *eth_drv = NULL;
        struct rte_pci_device *pci_dev = NULL;
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
@@ -416,6 +417,10 @@ eth_dev_null_create(const char *name,
        if (eth_dev == NULL)
                goto error;

+       eth_drv = rte_zmalloc_socket(name, sizeof(*eth_drv), 0, numa_node);
+       if (!eth_drv)
+               goto error;
+
        /* now put it all together
         * - store queue data in internals,
         * - store numa_node info in pci_driver
@@ -431,7 +436,10 @@ eth_dev_null_create(const char *name,
        internals->packet_copy = packet_copy;
        internals->numa_node = numa_node;

+       eth_drv->pci_drv.name = drivername;
+
        pci_dev->numa_node = numa_node;
+       pci_dev->driver = &eth_drv->pci_drv;

        data->dev_private = internals;
        data->port_id = eth_dev->data->port_id;
@@ -445,6 +453,7 @@ eth_dev_null_create(const char *name,
        eth_dev->dev_ops = &ops;
        eth_dev->pci_dev = pci_dev;
        eth_dev->driver = &rte_null_pmd;
+       TAILQ_INIT(&eth_dev->link_intr_cbs);

        /* finally assign rx and tx ops */
        if (packet_copy) {
@@ -461,6 +470,8 @@ error:
        rte_free(data);
        rte_free(pci_dev);
        rte_free(internals);
+       rte_free(eth_dev);
+       rte_free(eth_drv);

        return -1;
 }
-- 
1.7.9.5