On Wed, Dec 9, 2020 at 7:59 AM Juraj Linkeš <juraj.lin...@pantheon.tech> wrote: > > From: Ruifeng Wang <ruifeng.w...@arm.com> > > NEON vector path of the PMD needs aarch64 support. But it was > enabled for aarch32 build as well because aarch32 build had > cpu_family set to aarch64. So build for aarch32 will fail due > to unsupported intrinsics. > > Fixed aarch32 build by updating meson file to execule NEON vector > implementation for aarch32. > > Fixes: 398358341419 ("net/bnxt: support NEON") > Cc: lance.richard...@broadcom.com > Cc: sta...@dpdk.org > > Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com> > --- > drivers/net/bnxt/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build > index 2896337b5..a2fd494da 100644 > --- a/drivers/net/bnxt/meson.build > +++ b/drivers/net/bnxt/meson.build > @@ -74,6 +74,6 @@ sources = files('bnxt_cpr.c', > > if arch_subdir == 'x86' > sources += files('bnxt_rxtx_vec_sse.c') > -elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64') > +elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') > sources += files('bnxt_rxtx_vec_neon.c') > endif > -- > 2.20.1 > With this change, there should be no need for http://patchwork.dpdk.org/patch/84864/
Reviewed-by: Lance Richardson <lance.richard...@broadcom.com> -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.