> -----Original Message-----
> From: Lance Richardson <lance.richard...@broadcom.com>
> Sent: Wednesday, December 9, 2020 10:00 PM
> To: Juraj Linkeš <juraj.lin...@pantheon.tech>
> Cc: tho...@monjalon.net; Bruce Richardson <bruce.richard...@intel.com>;
> acon...@redhat.com; maicolgabr...@hotmail.com; dev@dpdk.org; Ruifeng
> Wang <ruifeng.w...@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v11 3/7] net/bnxt: add support for aarch32
>
> On Wed, Dec 9, 2020 at 8:00 AM Juraj Linkeš <juraj.lin...@pantheon.tech>
> wrote:
> >
> > From: Ruifeng Wang <ruifeng.w...@arm.com>
> >
> > Expand vector PMD support to aarch32.
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com>
> > Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_rxq.h | 2 +-
> > drivers/net/bnxt/bnxt_rxr.h | 2 +-
> > drivers/net/bnxt/bnxt_txr.h | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h
> > index c72105cf0..199bf976e 100644
> > --- a/drivers/net/bnxt/bnxt_rxq.h
> > +++ b/drivers/net/bnxt/bnxt_rxq.h
> > @@ -21,7 +21,7 @@ struct bnxt_rx_queue {
> > uint16_t nb_rx_desc; /* num of RX desc */
> > uint16_t rx_free_thresh; /* max free RX desc to hold
> > */
> > uint16_t queue_id; /* RX queue index */
> > -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> > uint16_t rxrearm_nb; /* number of descs to reinit. */
> > uint16_t rxrearm_start; /* next desc index to
> > reinit. */
> > #endif
> > diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
> > index 3fc901fdf..dcc07c713 100644
> > --- a/drivers/net/bnxt/bnxt_rxr.h
> > +++ b/drivers/net/bnxt/bnxt_rxr.h
> > @@ -83,7 +83,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq);
> > int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id);
> > int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id);
> >
> > -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> > uint16_t bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
> > uint16_t nb_pkts);
> > int bnxt_rxq_vec_setup(struct bnxt_rx_queue *rxq);
> > diff --git a/drivers/net/bnxt/bnxt_txr.h b/drivers/net/bnxt/bnxt_txr.h
> > index 3dfc8ef9b..3a47c3db7 100644
> > --- a/drivers/net/bnxt/bnxt_txr.h
> > +++ b/drivers/net/bnxt/bnxt_txr.h
> > @@ -49,7 +49,7 @@ int bnxt_init_one_tx_ring(struct bnxt_tx_queue *txq);
> > int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int
> socket_id);
> > uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
> > uint16_t nb_pkts);
> > -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> > uint16_t bnxt_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
> > uint16_t nb_pkts);
> > #endif
> > --
> > 2.20.1
> >
>
> NAK (still).
>
> These changes are pointless since bnxt_rxtx_vec_neon.c cannot be
> compiled in 32-bit mode.
>
This should be a mistake. Patch from prior version was picked.
Hi Juraj,
Can you please check?
We have an updated version for BNXT PMD.
Thanks.
> Regards,
> Lance
>
> --
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
