09/12/2020 01:21, Kadam, Pallavi: > On 12/6/2020 7:49 AM, Thomas Monjalon wrote: > > 05/12/2020 02:10, Pallavi Kadam: > >> --- a/lib/librte_eal/windows/include/rte_windows.h > >> +++ b/lib/librte_eal/windows/include/rte_windows.h > >> @@ -18,6 +18,11 @@ > >> #define WIN32_LEAN_AND_MEAN > >> #endif > >> > >> +#ifdef __clang__ > >> +#undef _m_prefetchw > >> +#define _m_prefetchw __m_prefetchw > >> +#endif > > > > These changes are not specific to i40e, please separate. > Ok, will create a separate patch in v2. > This change is required once we add rte_random.c file on windows. > So, may be addition of rte_random.c file and this change should go together? > Please suggest. Thanks,
Yes absolutely, addition of random feature should be atomic in a patch.