From: haz ben <benhaz1...@gmail.com> Sent: Tuesday, December 8, 2020 17:58 To: Wang, Haiyue <haiyue.w...@intel.com> Cc: ban, xiaozhen <benhaz1...@gmail.com>; Guo, Jia <jia....@intel.com>; dev@dpdk.org Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
my name is ban, xiaozhen. OK, ;-) the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add? It is not about additional, it is better for title + more descriptive message. Wang, Haiyue <haiyue.w...@intel.com<mailto:haiyue.w...@intel.com>> 于2020年12月8日周二 下午5:04写道： > -----Original Message----- > From: banxiaozhen benhaz1...@gmail.com<mailto:benhaz1...@gmail.com> > <banxiaozhen benhaz1...@gmail.com<mailto:benhaz1...@gmail.com>> > Sent: Tuesday, December 8, 2020 16:10 > To: Guo, Jia <jia....@intel.com<mailto:jia....@intel.com>>; Wang, Haiyue > <haiyue.w...@intel.com<mailto:haiyue.w...@intel.com>> > Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen > <benhaz1...@gmail.com<mailto:benhaz1...@gmail.com>> > Subject: [PATCH] net/e1000: fix incorrect return value if filter type not > supported. > > From: banxiaozhen <benhaz1...@gmail.com<mailto:benhaz1...@gmail.com>> > > Signed-off-by: banxiaozhen <benhaz1...@gmail.com<mailto:benhaz1...@gmail.com>> The patch looks good. The name format should be like "Banxiao Zhen", and the commit message is empty ? > --- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c > index 647aa8d99..8695426c2 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev > __rte_unused, > default: > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > filter_type); > + ret = -EINVAL; > break; > } > > -- > 2.24.3 (Apple Git-128)
