Hi, Haiyue > -----邮件原件----- > 发件人: Wang, Haiyue <haiyue.w...@intel.com> > 发送时间: 2020年11月18日 16:34 > 收件人: Feifei Wang <feifei.wa...@arm.com>; jer...@marvell.com; Ruifeng > Wang <ruifeng.w...@arm.com>; Guo, Jia <jia....@intel.com> > 抄送: dev@dpdk.org; nd <n...@arm.com> > 主题: RE: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm > > Hi Feifei, > > > -----Original Message----- > > From: Feifei Wang <feifei.wa...@arm.com> > > Sent: Wednesday, November 18, 2020 15:35 > > To: Jerin Jacob <jer...@marvell.com>; Ruifeng Wang > > <ruifeng.w...@arm.com>; Guo, Jia <jia....@intel.com>; Wang, Haiyue > > <haiyue.w...@intel.com> > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang <feifei.wa...@arm.com> > > Subject: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm > > > > And the commit message can be more descriptive like: > http://git.dpdk.org/dpdk/commit/?id=6d28c53bf7a9063caa3197c6cc481e2a69e > 3be96 > > No need to add the test result, you can put the result into cover letter. > > BR, > Haiyue
Thanks very much for your advice, the commit message has been changed in the new version. Best Regards Feifei > > > Implemented PKT_RX_VLAN_STRIPPED for vector PMD on Arm platform. > > > > Test Results: > > NICs: 82599(igb) > > Driver: ixgbe(vector) > > Packet: vlan-id=1 > > > > $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i > > --port-topology=chained \ to enable vlan stripping: > > --enable-hw-vlan-strip > > test-pmd> set fwd rxonly > > test-pmd> set verbose 1 > > test-pmd> start > > > > With this patch: > > %enable vlan stripping: > > testpmd> port 0/queue 0: received 1 packets > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - > > length=70 - nb_segs=1 - VLAN tci=0x1 > > ol_flags: PKT_RX_VLAN PKT_RX_VLAN_STRIPPED > > > > %disable vlan stripping: > > testpmd> port 0/queue 0: received 1 packets > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 - > > length=74 - nb_segs=1 - VLAN tci=0x0 > > ol_flags: PKT_RX_VLAN > > > > Without this patch: > > %enable vlan stripping: > > testpmd> port 0/queue 0: received 1 packets > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - > > length=70 - nb_segs=1 - VLAN tci=0x1 > > ol_flags: PKT_RX_VLAN > > > > %disable vlan stripping: > > testpmd> port 0/queue 0: received 1 packets > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 - > > length=74 - nb_segs=1 - VLAN tci=0x0 > > ol_flags: PKT_RX_VLAN > > > > > > Signed-off-by: Feifei Wang <feifei.wa...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > --- > > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 36 > > ++++++++++++++++--------- > > 1 file changed, 23 insertions(+), 13 deletions(-) > > > > > > 2.17.1
