On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > Rather than just installing all examples, we can use the build checks to > filter out any examples that are missing dependencies or are otherwise > unbuildable on the current system. > Introduce a new "buildable" special value for the -Dexamples= meson > option, this way existing behavior on installing all examples is > preserved. > > Select only buildable examples and test their compilation for the > x86-default target. > > Note for maintainers/users of the script: for existing environments, > the x86-default target might get broken by this patch since the script > now tries to build all "installed" examples and dependencies for some > might be unfulfilled. > To fix this temporary situation, you can either delete the whole > directory or reconfigure it: > $ meson configure $DPDK_BUILD_TEST_DIR/build-x86-default \ > -Dexamples=buildable > > Suggested-by: Bruce Richardson <bruce.richard...@intel.com> > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > Changelog since v1: > - rebased on main, > - introduced a new "buildable" special value for the -Dexamples option, > - installation of the "multi-level" examples has been fixed, so > corresponding exceptions have been removed, > - a fix for the vhost is waiting in next-virtio, I assume it will get > pulled before this series, > - the only remaining exception is for vm_power_manager which is broken, > > --- I'm not sure my "suggested-by" should be on this, since the idea of adding an extra buildable option is not mine here. I actually think I prefer the previous approach based on your original suggestion of always skipping unbuildable examples. Two reasons for that: * I'm not fully sure of the value of installing examples that can't be built, which was the original issue you raised. * I don't like mixing together two separate things - examples to build, and examples to install in a single option.
Therefore, I think we should choose one of two less confusing paths - either lets just always install all applications, or let's always install only those apps which can be built. I'm not massively concerned either way which is chosen, but I don't think we should try and support both and overload options to do so. /Bruce
