On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > My only comment is about vm_power_manager which won't build without > > the internal librte_power header. > > It builds fine with meson, because I guess meson pulls this library > > directory into the include flags of the example, but it won't build > > outside. > > > > We can skip it in devtools/test-meson-builds.sh but, on the other > > hand, I would exclude it from installing until it is fixed (in a > > future release). > > > Yes, good point. > Rather than adding special logic for it, I think we just add it in the > initialization of the exclusion array in patch 4, i.e. > > -dpdk_examples_exclude = []$ > +dpdk_examples_exclude = ['vm_power_manager'] > > Can this be done on apply, or do you want a v5 for it?
CI is happy with v4. I tested this additional change, lgtm too. I would add something in the commitlog to give some context: """ vm_power_manager relies on an internal header and can't build outside the dpdk tree. Hence, it is still built with meson but it is excluded from install examples until it has been fixed. """ WDYT? -- David Marchand
