Hi Abhinandan,
> Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback functions
>
> Hi Akhil,
>
> Can you please go through the patch again and check if any more comments?
As I suggested 2 times that there are documentation issues. Haven't seen a
version
To fix that. Please check it at your end and try fixing the timing of your
system so that CI
Can pick it for compilation.
> I understand that we work in same time zone, getting feedback from you in the
> mid night will not help me/you to pull this patch in.
> A quick response will enable me to prepare patch set quickly and send it
> across.
I am not dedicatedly working on your patchset. I will work as per my priorities.
Had it been a CI pass for compilation for both documentation and code,
it would have been applied last night. I could remove those extra spaces,
but there are other issues also as the newly added APIs are not visible in html
files generated. Please ensure that there are no issues in doxygen build issues
and
should be able to see the newly added APIs in html guides.
And please note, do not top post your comments. It becomes difficult to read it
in
Archives.
>
> This time, I will prepare the patch along with dequeue test case.
> Hope you understand the concern. Thanks..
>
> >
> > Hi Abhinandan,
> >
> > > Hi Akhil,
> > >
> > > What is the status of this patch? Is it pulled into RC2?
> > >
> > >
> > As I suggested below, please fix your date and let the CI pick your patches
> > for
> > build.
> > In my local build for documentation, the newly added APIs are not added in
> > the
> > Documentation. Please fix doxygen issues as soon as possible.
> > Did you try building documentation at your end?
> >
> > Regards,
> > Akhil
> >
> > > >
> > > > Regarding the date, I am not sure how it can be fixed now.
> > > > May be the space is missed out as well. Could be please help?
> > > >
> > > > >
> > > > > > +struct rte_cryptodev_cb {
> > > > > > + struct rte_cryptodev_cb *next;
> > > > > > + /** < Pointer to next callback */
> > > > > > + rte_cryptodev_callback_fn fn;
> > > > > > + /** < Pointer to callback function */
> > > > > > + void *arg;
> > > > > > + /** < Pointer to argument */
> > > > > > +};
> > > > > > +
> > > > > > +/**
> > > > > > + * @internal
> > > > > > + * Structure used to hold information about the RCU for a queue
> > > > > > pair.
> > > > > > + */
> > > > > > +struct rte_cryptodev_cb_rcu {
> > > > > > + struct rte_cryptodev_cb *next;
> > > > > > + /** < Pointer to next callback */
> > > > > > + struct rte_rcu_qsbr *qsbr;
> > > > > > + /** < RCU QSBR variable per queue pair */ }; #endif
> > > > > There is an extra space in each of the comments above between * and <.
> > > > > Check other doxygen errors if any.
> > > > >
> > > > > I believe the timestamp in your system is not correct, as the
> > > > > patchwork show Date of 2 days back while the patches are sent today.
> > > > > Could you please check? I believe CI server is not picking your
> > > > > patches for auto build.
> > > > > Please correct it so that auto build can happen. None of your
> > > > > version was picked by CI.
