Hi Akhil,
Can you please go through the patch again and check if any more comments?
I understand that we work in same time zone, getting feedback from you in the
mid night will not help me/you to pull this patch in.
A quick response will enable me to prepare patch set quickly and send it across.
This time, I will prepare the patch along with dequeue test case.
Hope you understand the concern. Thanks..
Regards
Abhinandan
> -----Original Message-----
> From: Akhil Goyal <akhil.go...@nxp.com>
> Sent: Tuesday, November 3, 2020 12:28 AM
> To: Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; dev@dpdk.org;
> Doherty, Declan <declan.dohe...@intel.com>;
> honnappa.nagaraha...@arm.com; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>
> Cc: Vangati, Narender <narender.vang...@intel.com>; jer...@marvell.com
> Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback functions
>
> Hi Abhinandan,
>
> > Hi Akhil,
> >
> > What is the status of this patch? Is it pulled into RC2?
> >
> >
> As I suggested below, please fix your date and let the CI pick your patches
> for
> build.
> In my local build for documentation, the newly added APIs are not added in the
> Documentation. Please fix doxygen issues as soon as possible.
> Did you try building documentation at your end?
>
> Regards,
> Akhil
>
> > >
> > > Regarding the date, I am not sure how it can be fixed now.
> > > May be the space is missed out as well. Could be please help?
> > >
> > > >
> > > > > +struct rte_cryptodev_cb {
> > > > > + struct rte_cryptodev_cb *next;
> > > > > + /** < Pointer to next callback */
> > > > > + rte_cryptodev_callback_fn fn;
> > > > > + /** < Pointer to callback function */
> > > > > + void *arg;
> > > > > + /** < Pointer to argument */
> > > > > +};
> > > > > +
> > > > > +/**
> > > > > + * @internal
> > > > > + * Structure used to hold information about the RCU for a queue pair.
> > > > > + */
> > > > > +struct rte_cryptodev_cb_rcu {
> > > > > + struct rte_cryptodev_cb *next;
> > > > > + /** < Pointer to next callback */
> > > > > + struct rte_rcu_qsbr *qsbr;
> > > > > + /** < RCU QSBR variable per queue pair */ }; #endif
> > > > There is an extra space in each of the comments above between * and <.
> > > > Check other doxygen errors if any.
> > > >
> > > > I believe the timestamp in your system is not correct, as the
> > > > patchwork show Date of 2 days back while the patches are sent today.
> > > > Could you please check? I believe CI server is not picking your
> > > > patches for auto build.
> > > > Please correct it so that auto build can happen. None of your
> > > > version was picked by CI.
