> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Tuesday, November 10, 2020 9:51 AM > To: McDaniel, Timothy <timothy.mcdan...@intel.com> > Cc: dev <dev@dpdk.org>; Carrillo, Erik G <erik.g.carri...@intel.com>; Eads, > Gage <gage.e...@intel.com>; Van Haaren, Harry > <harry.van.haa...@intel.com>; Jerin Jacob Kollanukkaran > <jer...@marvell.com>; Thomas Monjalon <tho...@monjalon.net>; Gaetan > Rivet <gr...@u256.net> > Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD > > On Tue, Nov 10, 2020 at 4:29 PM McDaniel, Timothy > <timothy.mcdan...@intel.com> wrote: > > > > I'm not seeing where we can use librte_pci here. We are already using the > dpdk low level rte_pci_read_config(..) APIs. > > Am I missing something? > > dlb_pci_find_ext_capability is a copy of rte_pci_find_ext_capability > from the pci bus. > > A lot of DLB_PCI_* defines have a librte_pci equivalent. > Plus, if there are generic pci defines needed by DLB, they would > rather belong to librte_pci than a driver. > > > -- > David Marchand
David, I just uploaded patches that should address most of your concerns. See https://patches.dpdk.org/patch/84034/ and https://patches.dpdk.org/patch/84031/ Thanks, Tim
