------------------ Original ------------------ From: "Tony Lu";<z...@ezchip.com>; Date: Jul 9, 2015 To: "'Thomas Monjalon'"<thomas.monjalon at 6wind.com>; Cc: "dev"<dev at dpdk.org>; Subject: Re: [dpdk-dev] [PATCH v3 04/12] eal: allow empty compile time flags
>-----Original Message----- >From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >Sent: Thursday, July 09, 2015 8:46 AM >To: Zhigang Lu >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3 04/12] eal: allow empty compile time flags > >2015-07-06 16:51, Zhigang Lu: >> The rte_cpu_check_supported() code breaks with a "comparison is always >> false due to limited range of data type" when the compile_time_flags[] >> array is empty. Assigning the array dimension to a local variable >> apparently solves this. > Can someone explain why this feature is needed? I think it should be removed since it bring more troubles than benifit for the common users.