Hi Takuya, It has been difficult to receive comments on this series during 2.1 cycle. I see 3 reasons: - few people know OSv - the series is mixing C++ support and OSv environment - you are adding a third system to support while some work is in progress to reduce differences between Linux and BSD support.
I suggest to: - fix doc with John's help - split C++ and OSv patches - help to merge Linux and BSD common code - introduce a common config file for every environments - re-send OSv support series at the beginning of 2.2 cycle without RFC keyword Thanks for your work 2015-04-21 03:37, Takuya ASADA: > Any comments/suggestions? > > On Tue, Apr 7, 2015 at 3:58 AM, Takuya ASADA <syuu at cloudius-systems.com> > wrote: > > > This is 3rd version of OSv support patchset. > > > > Changelist: > > - sync with latest master > > - updated Capstan build script for OSv v0.19 > > - rte_eal_version.map fix > > - CONFIG_RTE_BUILD_SHARED_LIB=y and CONFIG_RTE_BUILD_COMBINE_LIBS=y by > > default > > - Check OSv NIC driver is loaded for each device, attach PMD only if OSv > > driver is not loaded > > - Use --maxnic on cmdline to skip loading OSv NIC driver > > - Don't enable MSI-X on virtio, since it's not enable when OSv NIC driver > > is not loaded > > > > Takuya ASADA (7): > > mk: support compiling C++ code > > eal: Add extern C on eal_hugepages.h > > eal: Add extern C on eal_thread.h > > eal: Add extern C on eal_private.h > > add OSv support > > app/test: support OSv > > doc: Add Getting Started Guide for OSv
