On Tue, Mar 24, 2015 at 10:52 PM, Neil Horman <nhorman at tuxdriver.com> wrote:
> On Sat, Mar 21, 2015 at 12:23:02PM +0900, Takuya ASADA wrote: > > Adding OSv support. > > Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access > devices, allocate contiguous memory, etc. > > > > Signed-off-by: Takuya ASADA <syuu at cloudius-systems.com> > > --- > > diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > b/lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h > > similarity index 100% > > copy from lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h > > copy to lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > b/lib/librte_eal/osvapp/eal/rte_eal_version.map > > similarity index 92% > > copy from lib/librte_eal/bsdapp/eal/rte_eal_version.map > > copy to lib/librte_eal/osvapp/eal/rte_eal_version.map > > index 67b6a6c..ebb584a 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/osvapp/eal/rte_eal_version.map > > @@ -31,24 +31,26 @@ DPDK_2.0 { > > rte_eal_get_physmem_layout; > > rte_eal_get_physmem_size; > > rte_eal_has_hugepages; > > - rte_eal_hpet_init; > > rte_eal_init; > > rte_eal_iopl_init; > > rte_eal_lcore_role; > > rte_eal_mp_remote_launch; > > rte_eal_mp_wait_lcore; > > + rte_eal_parse_devargs_str; > > + rte_eal_pci_close_one; > > rte_eal_pci_dump; > > rte_eal_pci_probe; > > + rte_eal_pci_probe_one; > > rte_eal_pci_register; > > rte_eal_pci_unregister; > > rte_eal_process_type; > > rte_eal_remote_launch; > > rte_eal_tailq_lookup; > > rte_eal_tailq_register; > > + rte_eal_vdev_init; > > + rte_eal_vdev_uninit; > > rte_eal_wait_lcore; > > rte_exit; > > - rte_get_hpet_cycles; > > - rte_get_hpet_hz; > > rte_get_tsc_hz; > > rte_hexdump; > > rte_intr_callback_register; > > @@ -86,9 +88,6 @@ DPDK_2.0 { > > rte_thread_get_affinity; > > rte_thread_set_affinity; > > rte_vlog; > > - rte_xen_dom0_memory_attach; > > - rte_xen_dom0_memory_init; > > - test_mp_secondary; > > > I understand removing symbols that you don't support, but why are you > adding the > vdev, pci and parsing symbols? I don't see you using them anywhere in your > code... > This was because I copied rte_eal_version.map from linuxapp, but git format-patch generated diff from bsdapp. But osvapp don't have these symbols, so I dropped these lines. Please check v3 patchset which I just posted. > Neil > >