16/10/2020 14:16, Ferruh Yigit: > On 10/14/2020 3:26 AM, Ferruh Yigit wrote: > > Queue stats are stored in 'struct rte_eth_stats' as array and array size > > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > > > As a result of technical board discussion, decided to remove the queue > > statistics from 'struct rte_eth_stats' in the long term. > > > > Instead PMDs should represent the queue statistics via xstats, this > > gives more flexibility on the number of the queues supported. > > > > Currently queue stats in the xstats are filled by ethdev layer, using > > some basic stats, when queue stats removed from basic stats the > > responsibility to fill the relevant xstats will be pushed to the PMDs. > > > > During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' > > device flag is created. Initially all PMDs using xstats set this flag. > > The PMDs implemented queue stats in the xstats should clear the flag. > > > > When all PMDs switch to the xstats for the queue stats, queue stats > > related fields from 'struct rte_eth_stats' will be removed, as well as > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > > removed. > > > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Hi Thomas, Andrew, > > What do you think having the patch for this release?
Acked-by: Thomas Monjalon <tho...@monjalon.net>
