Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats

[Wang, Haiyue]

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yi...@intel.com>
> Sent: Wednesday, October 14, 2020 10:27
> To: Yigit, Ferruh <ferruh.yi...@intel.com>; John W. Linville 
> <linvi...@tuxdriver.com>; Loftus, Ciara
> <ciara.lof...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Shepard Siegel
> <shepard.sie...@atomicrules.com>; Ed Czeck <ed.cz...@atomicrules.com>; John 
> Miller
> <john.mil...@atomicrules.com>; Igor Russkikh <igor.russk...@aquantia.com>; 
> Pavel Belous
> <pavel.bel...@aquantia.com>; Steven Webster <steven.webs...@windriver.com>; 
> Matt Peters
> <matt.pet...@windriver.com>; Somalapuram Amaranath <asoma...@amd.com>; Rasesh 
> Mody <rm...@marvell.com>;
> Shahed Shaikh <shsha...@marvell.com>; Ajit Khaparde 
> <ajit.khapa...@broadcom.com>; Somnath Kotur
> <somnath.ko...@broadcom.com>; Chas Williams <ch...@att.com>; Min Hu (Connor) 
> <humi...@huawei.com>;
> Rahul Lakkireddy <rahul.lakkire...@chelsio.com>; Hemant Agrawal 
> <hemant.agra...@nxp.com>; Sachin
> Saxena <sachin.sax...@oss.nxp.com>; Guo, Jia <jia....@intel.com>; Wang, 
> Haiyue <haiyue.w...@intel.com>;
> Marcin Wojtas <m...@semihalf.com>; Michal Krawczyk <m...@semihalf.com>; Guy 
> Tzalik <gtza...@amazon.com>;
> Evgeny Schemeilin <evge...@amazon.com>; Igor Chauskin <igo...@amazon.com>; 
> Gagandeep Singh
> <g.si...@nxp.com>; John Daley <johnd...@cisco.com>; Hyong Youb Kim 
> <hyon...@cisco.com>; Gaetan Rivet
> <gr...@u256.net>; Wang, Xiao W <xiao.w.w...@intel.com>; Ziyang Xuan 
> <xuanziya...@huawei.com>; Xiaoyun
> Wang <cloud.wangxiao...@huawei.com>; Guoyang Zhou <zhouguoy...@huawei.com>; 
> Wei Hu (Xavier)
> <xavier.hu...@huawei.com>; Yisen Zhuang <yisen.zhu...@huawei.com>; Xing, 
> Beilei
> <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Yang, Qiming 
> <qiming.y...@intel.com>;
> Alfredo Cardigliano <cardigli...@ntop.org>; Xu, Rosen <rosen...@intel.com>; 
> Shijith Thotton
> <sthot...@marvell.com>; Srisivasubramanian Srinivasan 
> <sriniva...@marvell.com>; Jakub Grajciar
> <jgraj...@cisco.com>; Matan Azrad <ma...@nvidia.com>; Shahaf Shuler 
> <shah...@nvidia.com>; Viacheslav
> Ovsiienko <viachesl...@nvidia.com>; Zyta Szpak <z...@semihalf.com>; Liron 
> Himi <lir...@marvell.com>;
> Stephen Hemminger <sthem...@microsoft.com>; K. Y. Srinivasan 
> <k...@microsoft.com>; Haiyang Zhang
> <haiya...@microsoft.com>; Long Li <lon...@microsoft.com>; Martin Spinler 
> <spin...@cesnet.cz>; Heinrich
> Kuhn <heinrich.k...@netronome.com>; Tetsuya Mukawa <mtetsu...@gmail.com>; 
> Harman Kalra
> <hka...@marvell.com>; Jerin Jacob <jer...@marvell.com>; Nithin Dabilpuram 
> <ndabilpu...@marvell.com>;
> Kiran Kumar K <kirankum...@marvell.com>; Akhil Goyal <akhil.go...@nxp.com>; 
> Richardson, Bruce
> <bruce.richard...@intel.com>; Andrew Rybchenko 
> <andrew.rybche...@oktetlabs.ru>; Wiles, Keith
> <keith.wi...@intel.com>; Maciej Czekaj <mcze...@marvell.com>; Maxime Coquelin
> <maxime.coque...@redhat.com>; Xia, Chenbo <chenbo....@intel.com>; Wang, 
> Zhihong
> <zhihong.w...@intel.com>; Yong Wang <yongw...@vmware.com>; Thomas Monjalon 
> <tho...@monjalon.net>
> Cc: dev@dpdk.org
> Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue 
> xstats
> 
> Queue stats are stored in 'struct rte_eth_stats' as array and array size
> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
> 
> As a result of technical board discussion, decided to remove the queue
> statistics from 'struct rte_eth_stats' in the long term.
> 
> Instead PMDs should represent the queue statistics via xstats, this
> gives more flexibility on the number of the queues supported.
> 
> Currently queue stats in the xstats are filled by ethdev layer, using
> some basic stats, when queue stats removed from basic stats the
> responsibility to fill the relevant xstats will be pushed to the PMDs.
> 
> During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'
> device flag is created. Initially all PMDs using xstats set this flag.
> The PMDs implemented queue stats in the xstats should clear the flag.
> 
> When all PMDs switch to the xstats for the queue stats, queue stats
> related fields from 'struct rte_eth_stats' will be removed, as well as
> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
> Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be
> removed.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
> ---


>  drivers/net/e1000/em_ethdev.c             |  1 +
>  drivers/net/e1000/igb_ethdev.c            |  2 ++
>  drivers/net/igc/igc_ethdev.c              |  1 +
>  drivers/net/ixgbe/ixgbe_ethdev.c          |  2 ++

For e1000, igc, ixgbe PMDs,
Acked-by: Haiyue Wang <haiyue.w...@intel.com>

>  /**
>   * Iterates over valid ethdev ports owned by a specific owner.
> --
> 2.26.2