> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Friday, October 16, 2020 12:50 PM > To: Laatz, Kevin <kevin.la...@intel.com>; Van Haaren, Harry > <harry.van.haa...@intel.com> > Cc: dev <dev@dpdk.org>; Lukasz Wojciechowski > <l.wojciec...@partner.samsung.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; Phil Yang <phil.y...@arm.com>; Aaron > Conole <acon...@redhat.com> > Subject: Re: [PATCH] test/service: fix race condition on stopping lcore > > On Fri, Oct 16, 2020 at 11:13 AM Kevin Laatz <kevin.la...@intel.com> wrote: > > > > There is a potential race condition in 'service_attr_get' which will cause > > test failures since the service core thread is still running while the > > values are being retrieved/reset. > > > > This patch fixes the race condition by waiting for the service core thread > > to stop before continuing with the unit test checks. > > We won't backport it, since we need a new API, but I would flag it for info > as: > Fixes: 4d55194d76a4 ("service: add attribute get function") > > Ok for you?
Yes - thanks. > David Marchand