> -----Original Message----- > From: Laatz, Kevin <[email protected]> > Sent: Friday, October 16, 2020 10:08 AM > To: [email protected] > Cc: Van Haaren, Harry <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > Laatz, Kevin <[email protected]> > Subject: [PATCH] test/service: fix race condition on stopping lcore > > There is a potential race condition in 'service_attr_get' which will cause > test failures since the service core thread is still running while the > values are being retrieved/reset. > > This patch fixes the race condition by waiting for the service core thread > to stop before continuing with the unit test checks. > > Signed-off-by: Kevin Laatz <[email protected]>
Thanks Kevin for handling; can't reproduce race-cond here, but by code review this is the correct fix, thanks also for refactoring the wait into its own function. Acked-by: Harry van Haaren <[email protected]>
