On 9/18/2020 3:17 PM, Ophir Munk wrote:
v1:
Initial version
v2:
Rebased + Minor update in protocol options field:
char opts[0] ===> uint8_t opts[]
v3:
Rebase
document "geneve-port=N" parameter
v4:
Mispelling corrections
v5:
Rebase + Updates following review
http://patches.dpdk.org/patch/77734/
Ophir Munk (3):
app/testpmd: add GENEVE parsing
app/testpmd: enable configuring GENEVE port
app/testpmd: reduce tunnel parsing code duplication
Hi Ophir,
The patchset looks good except a few comments I put into the patches.
But I have two highlevel questions/comments,
1) The testpmd tunnel parsing feature is not documented properly, there are
various related commands but there is no documentation to put all together.
What do you think putting a new section for it under the "Testpmd Runtime
Functions" (testpmd_funcs.rst) with this patchset?
2) The 'csum' forwarding engine seems become forwarding engine for the case
where packet payload needs to be parsed, like gro/gso, tunnel parse. Even the
description of the forwarding engine in the documentation is not accurate now.
I wonder if we should rename the forwarding engine at this stage?
